[Bug 1780820] [NEW] Replace #binaryReadStream with #readStream

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

[Bug 1780820] [NEW] Replace #binaryReadStream with #readStream

Hliaire Fernandes
Administrator
Public bug reported:

In transition to the new Pharo7 File system, several #binaryReadStream messages should be replaced by #readStream.
All in all, only the XML operations are concerned. Image/PNG document should go with a #binaryReadStream

It occurs there bellow, methods body should be rewritten as follow:

DrGeoXml>>#load:for:
^ self
 loadFrom: (filename asFileReference readStream)
 for: constructor

Add comment for any additional finding.

** Affects: drgeo
     Importance: Critical
         Status: New


** Tags: core

** Tags removed: co
** Tags added: core

** Description changed:

- In transition to the new Pharo7 File system, several #binaryReadStream
- messages should be replaced by #readStream
+ In transition to the new Pharo7 File system, several #binaryReadStream messages should be replaced by #readStream.
+ All in all, only the XML operations are concerned. Image/PNG document should go with a #binaryReadStream
 
  It occurs there bellow, methods body should be rewritten as follow:
 
  DrGeoXml>>#load:for:
- ^ self
- loadFrom: (filename asFileReference readStream)
- for: constructor
+ ^ self
+  loadFrom: (filename asFileReference readStream)
+  for: constructor
 
  Add comment for any additional finding.

--
You received this bug notification because you are a member of DrGeo
developers, which is subscribed to Dr. Geo II.
Matching subscriptions: Dr. Geo bug report
https://bugs.launchpad.net/bugs/1780820

Title:
  Replace #binaryReadStream with #readStream

Status in Dr. Geo II:
  New

Bug description:
  In transition to the new Pharo7 File system, several #binaryReadStream messages should be replaced by #readStream.
  All in all, only the XML operations are concerned. Image/PNG document should go with a #binaryReadStream

  It occurs there bellow, methods body should be rewritten as follow:

  DrGeoXml>>#load:for:
  ^ self
   loadFrom: (filename asFileReference readStream)
   for: constructor

  Add comment for any additional finding.

To manage notifications about this bug go to:
https://bugs.launchpad.net/drgeo/+bug/1780820/+subscriptions

Reply | Threaded
Open this post in threaded view
|

[Bug 1780820] Re: Replace #binaryReadStream with #readStream

Hliaire Fernandes
Administrator
** Changed in: drgeo
    Milestone: wip => 18.06

--
You received this bug notification because you are a member of DrGeo
developers, which is subscribed to Dr. Geo II.
Matching subscriptions: Dr. Geo bug report
https://bugs.launchpad.net/bugs/1780820

Title:
  Replace #binaryReadStream with #readStream

Status in Dr. Geo II:
  New

Bug description:
  In transition to the new Pharo7 File system, several #binaryReadStream messages should be replaced by #readStream.
  All in all, only the XML operations are concerned. Image/PNG document should go with a #binaryReadStream

  It occurs there bellow, methods body should be rewritten as follow:

  DrGeoXml>>#load:for:
  ^ self
   loadFrom: (filename asFileReference readStream)
   for: constructor

  Add comment for any additional finding.

To manage notifications about this bug go to:
https://bugs.launchpad.net/drgeo/+bug/1780820/+subscriptions